-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Pioneer SR IR remotes #3308
Add support for Pioneer SR IR remotes #3308
Conversation
@radioegor146 can you also add unit tests to https://github.com/flipperdevices/flipperzero-firmware/blob/dev/applications/debug/unit_tests/infrared/infrared_test.c ? |
Working on it! |
@skotopes does infrared testset work currenly? Because as I try to run |
Yes, all PRs are going through unit tests. |
@gsurkov can you do review? |
@radioegor146 Is there any progress on unit tests? Do you need help with that? |
Thanks for helping with tests |
@radioegor146 I've modified the decoder a bit so that it would accept the input from its own encoder (it wasn't the case due to different stop bit handling in either of them) |
* add support for Pioneer SR IR remotes * fix minor issues * fix repeat * Fix protocol enumeration order * Add unit tests for Pioneer IR protocol * Clean up raw test data * Add encoder/decoder tests, modify parser * Remove dead code * Use loops where appropriate Co-authored-by: Georgii Surkov <37121527+gsurkov@users.noreply.github.com> Co-authored-by: Georgii Surkov <georgii.surkov@outlook.com>
I need help understanding everithing but I really what I see can somebody take there time and help me I promise I will make I back to you and I just got my flipper and I want to learn how to use it |
|
What's new
Verification
Checklist (For Reviewer)